UpdateWorkflow ShardId based metrics #5080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what has changed in this PR
Add shardId to updateworkflow. Also created a reusable thing to add more metrics around shardIds if needed.
Tell your future self why have you made these changes
For hotshard detection
How have you verified this change? Tested locally? Added a unit test? Checked in staging env?
Tested on staging
https://ugrafana.uberinternal.com/d/000058231/cadence-persistence?editPanel=60&orgId=1&from=now-30m&to=now&var-deployment=staging-dca&var-deployment=staging-phx&var-services=All&var-latency=p99&var-operation=All
Assuming the worst case, what can be broken when deploying this change to production?
Metrics for updateworkflow break