Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateWorkflow ShardId based metrics #5080

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

allenchen2244
Copy link
Contributor

@allenchen2244 allenchen2244 commented Feb 8, 2023

Describe what has changed in this PR

Add shardId to updateworkflow. Also created a reusable thing to add more metrics around shardIds if needed.

Tell your future self why have you made these changes
For hotshard detection

How have you verified this change? Tested locally? Added a unit test? Checked in staging env?
Tested on staging
https://ugrafana.uberinternal.com/d/000058231/cadence-persistence?editPanel=60&orgId=1&from=now-30m&to=now&var-deployment=staging-dca&var-deployment=staging-phx&var-services=All&var-latency=p99&var-operation=All

Assuming the worst case, what can be broken when deploying this change to production?
Metrics for updateworkflow break

@coveralls
Copy link

coveralls commented Feb 8, 2023

Pull Request Test Coverage Report for Build 01863341-0050-4d73-9d3c-aecb2d5d5cb6

  • 21 of 25 (84.0%) changed or added relevant lines in 2 files are covered.
  • 68 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.02%) to 57.192%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/persistenceMetricClients.go 18 22 81.82%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
common/cache/lru.go 2 92.2%
common/persistence/sql/sqlExecutionStore.go 2 63.68%
service/history/queue/timer_gate.go 3 95.83%
service/history/task/fetcher.go 4 91.24%
service/history/task/transfer_standby_task_executor.go 4 86.4%
service/matching/taskListManager.go 4 76.62%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 71.05%
common/persistence/nosql/nosqlTaskStore.go 16 58.37%
service/history/execution/mutable_state_task_refresher.go 18 61.08%
Totals Coverage Status
Change from base Build 01863285-fe52-44b0-96cc-d726dd6d1034: 0.02%
Covered Lines: 84936
Relevant Lines: 148510

💛 - Coveralls

@allenchen2244 allenchen2244 changed the title UpdateWorkflow ShardId based metrics WIP UpdateWorkflow ShardId based metrics Feb 8, 2023
Copy link
Member

@neil-xie neil-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@allenchen2244 allenchen2244 merged commit f5efe3a into master Feb 8, 2023
@allenchen2244 allenchen2244 deleted the updateworkflow-shard-metrics branch February 8, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants