Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change to emit wf version #5066

Merged
merged 3 commits into from
Jan 10, 2023
Merged

change to emit wf version #5066

merged 3 commits into from
Jan 10, 2023

Conversation

allenchen2244
Copy link
Contributor

Add wf version tag and change query to nested agg

neil-xie
neil-xie approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@neil-xie neil-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@allenchen2244 allenchen2244 enabled auto-merge (squash) January 9, 2023 22:52
@coveralls
Copy link

coveralls commented Jan 10, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 0185990d-defd-4ef8-ab37-9d3896b5e856

  • 32 of 32 (100.0%) changed or added relevant lines in 1 file are covered.
  • 18 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.08%) to 57.216%
Files with Coverage Reduction New Missed Lines %
common/task/fifoTaskScheduler.go 2 84.54%
service/history/handler.go 2 47.28%
service/history/task/fetcher.go 3 91.75%
service/matching/taskListManager.go 3 75.87%
common/types/history.go 4 46.26%
service/history/historyEngine.go 4 68.94%
Totals Coverage Status
Change from base Build 018598e7-1b95-4f57-8aca-afee85b14829: 0.08%
Covered Lines: 84952
Relevant Lines: 148476
💛 - Coveralls

@allenchen2244 allenchen2244 merged commit 60a6746 into master Jan 10, 2023
@allenchen2244 allenchen2244 deleted the workflow-version-withtype branch January 10, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neil-xie neil-xie neil-xie approved these changes

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allenchen2244 @coveralls @neil-xie