Add funcorder linter #4939
Merged
Add funcorder linter #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
force-pushed
the
reorder
branch
2 times, most recently
from
58554de to
d695ffe
Compare
Shaddoll
reviewed
Aug 11, 2022
| "golang.org/x/tools/go/analysis/singlechecker" | ||
| ) | ||
|
|
||
| func main() { |
There was a problem hiding this comment.
How is the tool used? Do we need to run it manually? Do we need to pass the file we want to fix?
There was a problem hiding this comment.
Currently it's a script that runs manually. go run main.go will output the command line.
There was a problem hiding this comment.
I'm guessing this isn't hooked into the make lint step yet? should that be done?
There was a problem hiding this comment.
ah. and we should probably move this to internal/tools/go.mod
Shaddoll
approved these changes
Aug 11, 2022
ZackLK
pushed a commit
that referenced
this pull request
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We need to sort the order of access methods in preparation for add codegen components. So I wrote a simple ast-based linter that automatically scan through the package and apply the changes.
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes