Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions from TaskAckManager #4872

Conversation

vytautas-karpavicius
Copy link
Contributor

@vytautas-karpavicius vytautas-karpavicius commented Jun 21, 2022

What changed?
Removed few functions and related tests from TaskAckManager.

Why?
Not used.

How did you test it?
Existing tests.

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 01818616-b903-445e-855e-6281468a2fc6

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 70 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.01%) to 57.982%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
common/membership/hashring.go 2 83.54%
common/persistence/executionManager.go 2 78.2%
common/persistence/statsComputer.go 2 96.43%
service/matching/taskListManager.go 2 73.77%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 57.59%
common/persistence/sql/sqlExecutionStore.go 5 64.38%
common/task/fifoTaskScheduler.go 5 84.54%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 8 77.95%
service/history/shard/context.go 9 65.9%
Totals Coverage Status
Change from base Build 018172c3-c0f4-4224-bc77-07a7f98d519f: -0.01%
Covered Lines: 83942
Relevant Lines: 144772

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review June 21, 2022 12:56
@vytautas-karpavicius vytautas-karpavicius requested a review from a team June 21, 2022 12:57
Copy link
Contributor

@mindaugasbarcauskas mindaugasbarcauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vytautas-karpavicius vytautas-karpavicius merged commit 608bcb5 into cadence-workflow:master Jun 21, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the cleanup-taskaskmanager branch June 21, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants