-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dynamic config #4863
Merged
Merged
Refactor dynamic config #4863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a82f628
to
a5beda0
Compare
cb38edc
to
088bf57
Compare
088bf57
to
51a1930
Compare
Groxx
reviewed
Jun 28, 2022
Shaddoll
commented
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
Groxx
reviewed
Jun 28, 2022
ab71d58
to
597b390
Compare
3c56a6c
to
bc10296
Compare
Groxx
reviewed
Jun 29, 2022
bc10296
to
d23cd4d
Compare
Groxx
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall much improved I think, thanks a lot for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
The default values and types of dynamic properties are declared in comments and therefore are not enforced in our code. People can make a mistake when using these dynamic properties.
How did you test it?
unit test
Potential risks
the default value of
system.enableVisibilitySampling
was incorrectly set totrue
in frontend, and we fixed it in this PR.If the frontend was depending on the default value of this property, the behavior is changed in this PR, which means read from elasticsearch is not sampled.
Release notes
Documentation Changes