Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused internal type getters #4852

Conversation

vytautas-karpavicius
Copy link
Contributor

@vytautas-karpavicius vytautas-karpavicius commented May 27, 2022

What changed?
Removed all unused internal type getters.

Why?
Dead code. We should move away from using them at all. Those are legacy from previously used Thrift types.

How did you test it?
Successful compilation is enough to ensure that they are not needed.

Potential risks

Release notes

Documentation Changes

@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review May 27, 2022 14:54
@vytautas-karpavicius vytautas-karpavicius requested a review from a team May 27, 2022 14:54
@coveralls
Copy link

coveralls commented May 27, 2022

Pull Request Test Coverage Report for Build 018113ed-24ec-4cf7-9307-3c5b372498d7

  • 26 of 31 (83.87%) changed or added relevant lines in 1 file are covered.
  • 72 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+1.1%) to 57.971%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/types/shared.go 26 31 83.87%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 2 41.75%
service/history/task/transfer_active_task_executor.go 2 71.41%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 57.59%
common/types/mapper/thrift/shared.go 4 63.9%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 12 77.59%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlTaskStore.go 16 58.37%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 19 86.32%
Totals Coverage Status
Change from base Build 018113ec-bab3-4ae2-aec2-c3e6e85b267c: 1.1%
Covered Lines: 83913
Relevant Lines: 144750

💛 - Coveralls

Copy link
Member

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Red diffs are good diffs

Also appreciate the move away from Java-isms

@vytautas-karpavicius vytautas-karpavicius merged commit 2408f9d into cadence-workflow:master May 30, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the unused-getters branch May 30, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants