-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use named port to select transport for outbound calls #4749
Merged
mantas-sidlauskas
merged 16 commits into
cadence-workflow:master
from
mantas-sidlauskas:ports
Mar 3, 2022
Merged
Use named port to select transport for outbound calls #4749
mantas-sidlauskas
merged 16 commits into
cadence-workflow:master
from
mantas-sidlauskas:ports
Mar 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7176497
to
7c6608b
Compare
e0ee2ef
to
5d63cc8
Compare
host/membership_resolver.go
Outdated
return m, nil | ||
} | ||
} | ||
return membership.HostInfo{}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, shouldn't his return an error? Loop is finished but host not found yet.
vytautas-karpavicius
approved these changes
Mar 2, 2022
mantas-sidlauskas
added a commit
that referenced
this pull request
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
AddressMapper is changed to named port setting.
Some additional changes in this PR:
CreateShardOwnershipLostError
is returningTChannel
address for backwards compatibilityLookupByAddress
returnsmembership.HostInfo
which is handy to find peer based on IP:port without knowing transport detailszaptest
as logger in unit testsWhy?
Named port (
tchannel
orgrpc
) will now define what transport is to be used for outbound calls.How did you test it?
Unit tests, integration tests
Potential risks
Release notes
Documentation Changes