Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide portmap to ringpop #4745

Merged

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
Passing port map to ringpop provider

Why?
Inbound ports from rpc config is now passed to Ringpop labels.

This will be used for easier migration between tchannel and gRPC as membership layer will expose available ports for ring members

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Feb 22, 2022

Pull Request Test Coverage Report for Build 61470c55-63cd-40db-ad32-e978a8d85777

  • 4 of 18 (22.22%) changed or added relevant lines in 4 files are covered.
  • 66 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.01%) to 56.915%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/server/cadence/server.go 0 4 0.0%
common/peerprovider/ringpopprovider/provider.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
common/peerprovider/ringpopprovider/provider.go 1 0%
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
common/types/shared.go 1 26.8%
common/task/fifoTaskScheduler.go 2 87.63%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 55.49%
common/types/mapper/thrift/shared.go 4 63.25%
service/history/task/fetcher.go 4 86.15%
common/persistence/nosql/nosqlExecutionStore.go 9 60.46%
service/history/queue/transfer_queue_processor.go 10 56.86%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 11 77.68%
Totals Coverage Status
Change from base Build c171ff94-d7d6-4274-b671-1da463ad6b6a: -0.01%
Covered Lines: 83078
Relevant Lines: 145969

💛 - Coveralls

@mantas-sidlauskas mantas-sidlauskas merged commit 9b50717 into cadence-workflow:master Feb 22, 2022
mantas-sidlauskas added a commit that referenced this pull request Feb 22, 2022
mantas-sidlauskas added a commit that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants