Move ringpop setup to common/membership #4638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantas-sidlauskas
force-pushed
the
move_ringpop_to_monitor
branch
from
220acc4 to
2cbc9de
Compare
Pull Request Test Coverage Report for Build 2e5164bd-82e7-4c0c-929a-12c65db0e105
💛 - Coveralls |
common/membership/ringpop_config.go
Outdated
| for _, service := range provider.UnresolvedHosts { | ||
| serviceParts := strings.Split(service, ".") | ||
| for _, host := range provider.UnresolvedHosts { | ||
| serviceParts := strings.Split(host, ".") |
There was a problem hiding this comment.
nit: maybe this should be hostParts as well. I find whole section quite confusing.
There was a problem hiding this comment.
thanks, will update
vytautas-karpavicius
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Ringpop creation is moved to common/membership
Why?
This is part of refactoring needed to introduce selectable membership providers
How did you test it?
Unit tests/local test
Potential risks
Release notes
Documentation Changes