Remove Membership Factory #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantas-sidlauskas
force-pushed
the
monitor
branch
from
9df25d2 to
ea9ce70
Compare
| "github.com/uber/cadence/common" | ||
| "github.com/uber/cadence/common/types" | ||
| ) | ||
|
|
||
| // ErrUnknownService is thrown for a service that is not tracked by this instance | ||
| var ErrUnknownService = errors.New("Service not tracked by Monitor") | ||
|
|
||
| // ErrInsufficientHosts is thrown when there are not enough hosts to serve the request | ||
| var ErrInsufficientHosts = &types.InternalServiceError{Message: "Not enough hosts to serve the request"} |
There was a problem hiding this comment.
What is the reason for removing up/below errors but not this one? All three of them does not seem to be used outside of this package.
There was a problem hiding this comment.
will address this in next PR
vytautas-karpavicius
approved these changes
Nov 10, 2021
mantas-sidlauskas
force-pushed
the
monitor
branch
from
6f2361f to
bd5f4c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
membership.Monitoris used instead ofMembershipMonitorFactoryWhy?
To simplify upcoming changes for pluggable
membershipoptions.How did you test it?
Unit tests/local test
Potential risks
Release notes
Documentation Changes