Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli: notify on SIGINT #4615

Merged

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
During start, handler will be notified on SIGINT

Why?
This will kick off all shutdown actions on Ctrl+C which is helpful during development and testing

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 698b2d44-7be2-4302-83db-c474bfc7afde

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 67 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.01%) to 56.889%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/server/cadence/cadence.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
client/history/client.go 2 40.32%
client/history/metricClient.go 2 45.94%
common/persistence/executionManager.go 2 76.32%
common/persistence/statsComputer.go 2 95.71%
common/task/parallelTaskProcessor.go 2 92.75%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/handler.go 2 48.42%
service/matching/taskListManager.go 2 74.66%
common/task/fifoTaskScheduler.go 3 84.54%
service/history/queue/timer_gate.go 3 95.83%
Totals Coverage Status
Change from base Build 90517954-e539-4a52-9ef3-2e35685d83cf: -0.01%
Covered Lines: 81997
Relevant Lines: 144136

💛 - Coveralls

@mantas-sidlauskas mantas-sidlauskas merged commit a370de0 into cadence-workflow:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants