Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Channel for Ringpop #4597

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
RPC factory provides Tchannel Channel

Why?
Ringpop doesn't need dispatcher anymore. Channel is retrieved from RPC factory without interface assertion

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build a5a98f32-f4d2-4b2c-bfd3-8330789688fe

  • 4 of 15 (26.67%) changed or added relevant lines in 3 files are covered.
  • 30 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.05%) to 56.834%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/rpc/factory.go 2 5 40.0%
cmd/server/cadence/server.go 0 4 0.0%
common/config/ringpop.go 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
service/history/execution/mutable_state_task_refresher.go 1 73.82%
client/history/client.go 2 40.32%
client/history/metricClient.go 2 45.94%
common/task/fifoTaskScheduler.go 2 84.54%
common/task/parallelTaskProcessor.go 2 92.75%
common/task/weightedRoundRobinTaskScheduler.go 2 88.6%
service/history/handler.go 2 48.32%
service/history/task/priority_assigner.go 2 89.74%
service/matching/matcher.go 2 91.46%
service/frontend/workflowHandler.go 4 58.59%
Totals Coverage Status
Change from base Build f3e4a4d4-c5e9-4a4c-9dbb-e9f3d64d0955: 0.05%
Covered Lines: 81641
Relevant Lines: 143648

💛 - Coveralls

@mantas-sidlauskas mantas-sidlauskas merged commit 9a072ca into cadence-workflow:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants