Fix and improve canary thrift config and docs #4580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix and improve canary config and docs
Why?
A previous PR has switched the canary to use gRPC only. This broke the docker compose canary and its docs.
There are OSS users like my team are still using Thrift and it will take some work to enable the gRPC ports on server.
Also some minor fixes to canary docs. Archival test case is failing because docker is now disabled it by default. So it's better to disable the test case. Plus archival is not a frequently used feature by many users. They can still enable it by removing the exclude it from the config.
How did you test it?
Potential risks
Release notes
Documentation Changes