Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve canary thrift config and docs #4580

Merged
merged 7 commits into from
Oct 19, 2021

Conversation

longquanzheng
Copy link
Contributor

@longquanzheng longquanzheng commented Oct 18, 2021

What changed?
Fix and improve canary config and docs

Why?
A previous PR has switched the canary to use gRPC only. This broke the docker compose canary and its docs.
There are OSS users like my team are still using Thrift and it will take some work to enable the gRPC ports on server.

Also some minor fixes to canary docs. Archival test case is failing because docker is now disabled it by default. So it's better to disable the test case. Plus archival is not a frequently used feature by many users. They can still enable it by removing the exclude it from the config.

How did you test it?

(qlong-fix-canary-thrift) $cadence --do cadence-canary workflow ob -w 'cadence.canary.cron-workflow.sanity-2021-10-18T17:24:05Z'
Progress:
  1, 2021-10-18T10:24:05-07:00, WorkflowExecutionStarted
  2, 2021-10-18T10:24:05-07:00, DecisionTaskScheduled
  3, 2021-10-18T10:24:05-07:00, DecisionTaskStarted
  4, 2021-10-18T10:24:05-07:00, DecisionTaskCompleted
  5, 2021-10-18T10:24:05-07:00, MarkerRecorded
  6, 2021-10-18T10:24:05-07:00, UpsertWorkflowSearchAttributes
  7, 2021-10-18T10:24:05-07:00, MarkerRecorded
  8, 2021-10-18T10:24:05-07:00, StartChildWorkflowExecutionInitiated
  9, 2021-10-18T10:24:05-07:00, StartChildWorkflowExecutionInitiated
  10, 2021-10-18T10:24:05-07:00, StartChildWorkflowExecutionInitiated
  11, 2021-10-18T10:24:05-07:00, StartChildWorkflowExecutionInitiated
  12, 2021-10-18T10:24:05-07:00, StartChildWorkflowExecutionInitiated
  13, 2021-10-18T10:24:05-07:00, StartChildWorkflowExecutionInitiated
  14, 2021-10-18T10:24:05-07:00, StartChildWorkflowExecutionInitiated
  15, 2021-10-18T10:24:05-07:00, StartChildWorkflowExecutionInitiated
  16, 2021-10-18T10:24:05-07:00, StartChildWorkflowExecutionInitiated
  17, 2021-10-18T10:24:05-07:00, StartChildWorkflowExecutionInitiated
  18, 2021-10-18T10:24:05-07:00, ChildWorkflowExecutionStarted
  19, 2021-10-18T10:24:05-07:00, DecisionTaskScheduled
  20, 2021-10-18T10:24:05-07:00, ChildWorkflowExecutionStarted
  21, 2021-10-18T10:24:05-07:00, ChildWorkflowExecutionStarted
  22, 2021-10-18T10:24:05-07:00, ChildWorkflowExecutionStarted
  23, 2021-10-18T10:24:05-07:00, ChildWorkflowExecutionStarted
  24, 2021-10-18T10:24:05-07:00, ChildWorkflowExecutionStarted
  25, 2021-10-18T10:24:05-07:00, ChildWorkflowExecutionStarted
  26, 2021-10-18T10:24:05-07:00, ChildWorkflowExecutionStarted
  27, 2021-10-18T10:24:05-07:00, ChildWorkflowExecutionStarted
  28, 2021-10-18T10:24:05-07:00, ChildWorkflowExecutionStarted
  29, 2021-10-18T10:24:05-07:00, DecisionTaskStarted
  30, 2021-10-18T10:24:05-07:00, DecisionTaskCompleted
  31, 2021-10-18T10:24:06-07:00, ChildWorkflowExecutionCompleted
  32, 2021-10-18T10:24:06-07:00, DecisionTaskScheduled
  33, 2021-10-18T10:24:06-07:00, DecisionTaskStarted
  34, 2021-10-18T10:24:06-07:00, DecisionTaskCompleted
  35, 2021-10-18T10:24:06-07:00, ChildWorkflowExecutionCompleted
  36, 2021-10-18T10:24:06-07:00, DecisionTaskScheduled
  37, 2021-10-18T10:24:06-07:00, DecisionTaskStarted
  38, 2021-10-18T10:24:06-07:00, DecisionTaskCompleted
  39, 2021-10-18T10:24:06-07:00, ChildWorkflowExecutionCompleted
  40, 2021-10-18T10:24:06-07:00, DecisionTaskScheduled
  41, 2021-10-18T10:24:06-07:00, DecisionTaskStarted
  42, 2021-10-18T10:24:06-07:00, DecisionTaskCompleted
  43, 2021-10-18T10:24:06-07:00, ChildWorkflowExecutionCompleted
  44, 2021-10-18T10:24:06-07:00, DecisionTaskScheduled
  45, 2021-10-18T10:24:06-07:00, DecisionTaskStarted
  46, 2021-10-18T10:24:06-07:00, DecisionTaskCompleted
  47, 2021-10-18T10:24:07-07:00, ChildWorkflowExecutionCompleted
  48, 2021-10-18T10:24:07-07:00, DecisionTaskScheduled
  49, 2021-10-18T10:24:07-07:00, DecisionTaskStarted
  50, 2021-10-18T10:24:07-07:00, DecisionTaskCompleted
  51, 2021-10-18T10:24:08-07:00, ChildWorkflowExecutionCompleted
  52, 2021-10-18T10:24:08-07:00, DecisionTaskScheduled
  53, 2021-10-18T10:24:08-07:00, DecisionTaskStarted
  54, 2021-10-18T10:24:08-07:00, DecisionTaskCompleted
  55, 2021-10-18T10:24:10-07:00, ChildWorkflowExecutionCompleted
  56, 2021-10-18T10:24:10-07:00, DecisionTaskScheduled
  57, 2021-10-18T10:24:10-07:00, DecisionTaskStarted
  58, 2021-10-18T10:24:10-07:00, DecisionTaskCompleted
  59, 2021-10-18T10:24:10-07:00, ChildWorkflowExecutionCompleted
  60, 2021-10-18T10:24:10-07:00, DecisionTaskScheduled
  61, 2021-10-18T10:24:10-07:00, DecisionTaskStarted
  62, 2021-10-18T10:24:10-07:00, DecisionTaskCompleted
  63, 2021-10-18T10:24:36-07:00, ChildWorkflowExecutionCompleted
  64, 2021-10-18T10:24:36-07:00, DecisionTaskScheduled
  65, 2021-10-18T10:24:36-07:00, DecisionTaskStarted
  66, 2021-10-18T10:24:36-07:00, DecisionTaskCompleted
  67, 2021-10-18T10:25:09-07:00, ChildWorkflowExecutionCompleted
  68, 2021-10-18T10:25:09-07:00, DecisionTaskScheduled
  69, 2021-10-18T10:25:09-07:00, DecisionTaskStarted
  70, 2021-10-18T10:25:09-07:00, DecisionTaskCompleted
  71, 2021-10-18T10:25:09-07:00, WorkflowExecutionCompleted

Result:
  Run Time: 50 seconds
  Status: COMPLETED
  Output:

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Oct 18, 2021

Pull Request Test Coverage Report for Build fc2db033-b3e8-42f9-81b5-0adb353dde44

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 81 unchanged lines in 14 files lost coverage.
  • Overall coverage decreased (-0.01%) to 56.846%

Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
service/history/execution/mutable_state_task_refresher.go 1 73.82%
common/persistence/executionManager.go 2 76.51%
common/persistence/statsComputer.go 2 96.43%
common/types/mapper/thrift/shared.go 2 63.43%
service/history/execution/mutable_state_builder.go 2 69.77%
service/matching/matcher.go 2 91.46%
service/history/queue/timer_queue_processor_base.go 4 78.83%
service/history/task/redispatcher.go 4 89.67%
common/persistence/sql/sqlExecutionStore.go 5 62.69%
Totals Coverage Status
Change from base Build dc586ea9-6efa-4a2a-bc8a-f6d9b2390e2d: -0.01%
Covered Lines: 81458
Relevant Lines: 143296

💛 - Coveralls

@longquanzheng longquanzheng enabled auto-merge (squash) October 18, 2021 19:00
@longquanzheng longquanzheng changed the title Fix and improve canary config and docs Fix and improve canary thrift config and docs Oct 18, 2021
@longquanzheng longquanzheng enabled auto-merge (squash) October 19, 2021 15:35
@longquanzheng longquanzheng merged commit 53833a2 into master Oct 19, 2021
@longquanzheng longquanzheng deleted the qlong-fix-canary-thrift branch October 19, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants