Remove dispatcher provider #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytautas-karpavicius
force-pushed
the
remove-dispatcher-provider
branch
from
d0b4e3c to
9014c62
Compare
mantas-sidlauskas
approved these changes
Oct 12, 2021
host/onebox.go
Outdated
| @@ -398,11 +395,10 @@ func (c *cadenceImpl) startFrontend(hosts map[string][]string, startWG *sync.Wai | |||
| params.ThrottledLogger = c.logger | |||
| params.UpdateLoggerWithServiceName(service.Frontend) | |||
| params.PProfInitializer = newPProfInitializerImpl(c.logger, c.FrontendPProfPort()) | |||
| params.RPCFactory = newRPCFactory(service.Frontend, c.FrontendAddress(), c.logger, c.clusterMetadata) | |||
| params.RPCFactory = newRPCFactory(service.Frontend, c.FrontendAddress(), c.FrontendAddress(), c.logger, c.clusterMetadata) | |||
There was a problem hiding this comment.
nit/optional it seems that c.FrontendAddress() has to be passed all the time, it would be nice if this can be taken automatically.
…avicius/cadence into remove-dispatcher-provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Removed dispatcher provider interface, implementation and related bits.
Why?
Not longer used, its details were moved to cross dc outbound builder in #4552.
How did you test it?
Potential risks
Release notes
Documentation Changes