Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve server_test and instructions on homebrew and dynamic config docs #4557

Merged
merged 7 commits into from
Oct 15, 2021

Conversation

longquanzheng
Copy link
Contributor

What changed?
Improve server_test and instructions on homebrew

Why?

How did you test it?
N/A

Potential risks
No

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Oct 11, 2021

Pull Request Test Coverage Report for Build fb3b6355-ec6e-4e3d-94be-dbef7da4bdd2

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 79 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.006%) to 56.817%

Files with Coverage Reduction New Missed Lines %
common/membership/rpServiceResolver.go 2 73.58%
common/task/fifoTaskScheduler.go 2 84.54%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 69.77%
service/history/queue/timer_queue_processor.go 2 59.33%
service/history/shard/context.go 2 66.69%
service/matching/matcher.go 2 91.46%
service/matching/taskListManager.go 2 74.09%
common/cache/lru.go 3 90.73%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 55.49%
Totals Coverage Status
Change from base Build abdd87f0-e244-4789-996a-013e1a186c92: 0.006%
Covered Lines: 81261
Relevant Lines: 143022

💛 - Coveralls

@github-actions github-actions bot force-pushed the qlong-misc-improve branch 4 times, most recently from 87adbd5 to c44c4ef Compare October 12, 2021 16:30
@@ -59,66 +59,66 @@ const (
// EnableGlobalDomain is key for enable global domain
// KeyName: system.enableGlobalDomain
// Value type: Bool
// Default value: FALSE
// Default value: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to reviewers: I change this file so that the default values are reflecting what should be set in the yaml format. I have seen many people got confused, for example they tried to use 256 * 1024 in the yaml.

@longquanzheng longquanzheng changed the title Improve server_test and instructions on homebrew Improve server_test and instructions on homebrew and dynamic config docs Oct 14, 2021
@longquanzheng longquanzheng merged commit f8f95d5 into master Oct 15, 2021
@longquanzheng longquanzheng deleted the qlong-misc-improve branch October 15, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants