Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused NewFrontendClient functions #4553

Conversation

vytautas-karpavicius
Copy link
Contributor

What changed?
Cleanup unused NewFrontendClient and NewFrontendClientWithTimeout functions.

Why?
To remove unused code.
We create our frontend clients via NewFrontendClientWithTimeoutAndConfig - which is used when creating DNS based cluster clients.

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Oct 8, 2021

Pull Request Test Coverage Report for Build 95278358-57f0-4142-8841-4e0de0a326bb

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 49 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.003%) to 56.714%

Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 26.64%
client/history/client.go 2 40.32%
client/history/metricClient.go 2 45.94%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 69.77%
service/history/handler.go 2 48.32%
service/history/queue/timer_queue_processor.go 2 59.33%
service/history/shard/context.go 2 65.93%
service/history/task/transfer_active_task_executor.go 2 70.93%
service/matching/matcher.go 2 91.46%
Totals Coverage Status
Change from base Build b1ed06a4-e64b-45c3-a7a9-4eab3790ab47: 0.003%
Covered Lines: 81040
Relevant Lines: 142893

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review October 8, 2021 14:17
@vytautas-karpavicius vytautas-karpavicius requested a review from a team October 8, 2021 14:18
@vytautas-karpavicius vytautas-karpavicius merged commit 7a6b851 into cadence-workflow:master Oct 11, 2021
@vytautas-karpavicius vytautas-karpavicius deleted the frontend-client-cleanup branch October 11, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants