Revert "Use common dispatcher for public client outbound (#4523)"

[vytautas-karpavicius]

This reverts commit a094a33.

What changed?
Issue was found, reverting to unblock Java client release.

Why?

{"level":"info","ts":"2021-10-04T12:07:22.965-0700","msg":"Received a ring changed event","service":"cadence-frontend","component":"service-resolver","logging-call-at":"rpServiceResolver.go:199"}
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x59faca6]

goroutine 2231 [running]:
go.uber.org/yarpc/internal/observability.(*Middleware).handlePanicForCall(0xc0001ad680, 0xc000702460, 0x6ae5ec0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/internal/observability/middleware.go:315 +0x18d
panic(0x6597860, 0x822cea0)
        /usr/local/go-dists/1.16.2/go/src/runtime/panic.go:965 +0x1b9
github.com/uber/cadence/common/rpc.(*authOutboundMiddleware).Call(0x0, 0x6ef1cf8, 0xc00140c780, 0xc00184a900, 0x6efae78, 0xc00124ae20, 0x0, 0x0, 0x0)
        /Users/qlong/cadence/common/rpc/middleware.go:37 +0x26
go.uber.org/yarpc/api/middleware.unaryOutboundWithMiddleware.Call(...)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/api/middleware/outbound.go:113
go.uber.org/yarpc/internal/outboundmiddleware.unaryChainExec.Call(0xc00124af10, 0x0, 0x0, 0x6efbeb8, 0xc000b234d0, 0x6ef1cf8, 0xc00140c780, 0xc00184a900, 0x825de40, 0x6ef1cf8, ...)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/internal/outboundmiddleware/chain.go:103 +0x8d
go.uber.org/yarpc/internal/observability.(*Middleware).Call(0xc0001ad680, 0x6ef1cf8, 0xc00140c780, 0xc00184a900, 0x6efbfb8, 0xc0006b5950, 0x0, 0x0, 0x0)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/internal/observability/middleware.go:213 +0x18a
go.uber.org/yarpc/internal/outboundmiddleware.unaryChainExec.Call(0xc00124af10, 0x0, 0x0, 0x6efbeb8, 0xc000b234d0, 0x6ef1cf8, 0xc00140c780, 0xc00184a900, 0x8fabc88, 0xc000b234d0, ...)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/internal/outboundmiddleware/chain.go:107 +0x195
go.uber.org/yarpc/internal/firstoutboundmiddleware.(*Middleware).Call(0x8292000, 0x6ef1cf8, 0xc00140c780, 0xc00184a900, 0x6efbfb8, 0xc0006b5920, 0x5555555555555555, 0x38, 0x8)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/internal/firstoutboundmiddleware/middleware.go:51 +0xac
go.uber.org/yarpc/internal/outboundmiddleware.unaryChainExec.Call(0xc00124af10, 0x1, 0x1, 0x6efbeb8, 0xc000b234d0, 0x6ef1cf8, 0xc00140c780, 0xc00184a900, 0x110, 0x672afc0, ...)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/internal/outboundmiddleware/chain.go:107 +0x195
go.uber.org/yarpc/internal/outboundmiddleware.unaryChain.Call(...)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/internal/outboundmiddleware/chain.go:67
go.uber.org/yarpc/api/middleware.unaryOutboundWithMiddleware.Call(...)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/api/middleware/outbound.go:113
go.uber.org/yarpc/internal/request.UnaryValidatorOutbound.Call(0x6efbeb8, 0xc000b23650, 0x8fabc88, 0xc000b23650, 0x6ef1cf8, 0xc00140c780, 0xc00184a900, 0x3, 0x4, 0xc0011bd6e0)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/internal/request/validator_outbound.go:46 +0xc8
go.uber.org/yarpc/encoding/thrift.thriftClient.Call(0x6ef2e78, 0xc000b0cb40, 0x6ef4618, 0x8292000, 0x69e2a29, 0xf, 0x0, 0x6ef1cf8, 0xc00140c780, 0x6ee4950, ...)
        /Users/qlong/go/pkg/mod/go.uber.org/yarpc@v1.56.0/encoding/thrift/outbound.go:145 +0x22d
go.uber.org/cadence/.gen/go/cadence/workflowserviceclient.client.DescribeDomain(0x6eca708, 0xc000d106c0, 0x6ef1cf8, 0xc00140c780, 0xc00184c250, 0xc00140c7e0, 0x4, 0x6, 0xc001847380, 0x825de40, ...)
        /Users/qlong/go/pkg/mod/go.uber.org/cadence@v0.17.1-0.20210820042115-b09692f6838f/.gen/go/cadence/workflowserviceclient/client.go:345 +0xff
go.uber.org/cadence/internal/common/metrics.(*workflowServiceMetricsWrapper).DescribeDomain(0xc0006b49c0, 0x6ef1cf8, 0xc00140c780, 0xc00184c250, 0xc00140c7e0, 0x4, 0x6, 0xc00140c780, 0xc00184c200, 0xc00140c7e0)
        /Users/qlong/go/pkg/mod/go.uber.org/cadence@v0.17.1-0.20210820042115-b09692f6838f/internal/common/metrics/service_wrapper.go:149 +0xb8
go.uber.org/cadence/internal.verifyDomainExist.func1(0x0, 0x0)
        /Users/qlong/go/pkg/mod/go.uber.org/cadence@v0.17.1-0.20210820042115-b09692f6838f/internal/internal_worker.go:251 +0x188
go.uber.org/cadence/internal/common/backoff.Retry(0x6ef1cc0, 0xc00019a008, 0xc001867bf0, 0x6e99aa0, 0xc000e4cf00, 0x6ae5d98, 0x0, 0xb)
        /Users/qlong/go/pkg/mod/go.uber.org/cadence@v0.17.1-0.20210820042115-b09692f6838f/internal/common/backoff/retry.go:98 +0xc9
go.uber.org/cadence/internal.verifyDomainExist(0x6f1a198, 0xc0006b49c0, 0x69e0bd6, 0xe, 0xc00140c5a0, 0x0, 0x0, 0x0)
        /Users/qlong/go/pkg/mod/go.uber.org/cadence@v0.17.1-0.20210820042115-b09692f6838f/internal/internal_worker.go:272 +0x18b
go.uber.org/cadence/internal.(*workflowWorker).Start(0xc0018481a0, 0xc000f86580, 0xb)
        /Users/qlong/go/pkg/mod/go.uber.org/cadence@v0.17.1-0.20210820042115-b09692f6838f/internal/internal_worker.go:367 +0x7a
go.uber.org/cadence/internal.(*aggregatedWorker).Start(0xc000b33c00, 0x0, 0x0)
        /Users/qlong/go/pkg/mod/go.uber.org/cadence@v0.17.1-0.20210820042115-b09692f6838f/internal/internal_worker.go:830 +0x568
github.com/uber/cadence/service/worker/archiver.(*clientWorker).Start(0xc0006ab640, 0x6ec82a0, 0xc0006ab640)
        /Users/qlong/cadence/service/worker/archiver/client_worker.go:117 +0x37
github.com/uber/cadence/service/worker.(*Service).startArchiver(0xc0007ce1e0)
        /Users/qlong/cadence/service/worker/service.go:326 +0x296
github.com/uber/cadence/service/worker.(*Service).Start(0xc0007ce1e0)
        /Users/qlong/cadence/service/worker/service.go:204 +0x43c
github.com/uber/cadence/cmd/server/cadence.execute(0x1022e1d8, 0xc0007ce1e0, 0xc000934120)
        /Users/qlong/cadence/cmd/server/cadence/server.go:260 +0x31
created by github.com/uber/cadence/cmd/server/cadence.(*server).startService
        /Users/qlong/cadence/cmd/server/cadence/server.go:253 +0x14f5

Process finished with exit code 2

How did you test it?

Potential risks

Release notes

Documentation Changes

[mkolodezny]

lgtm

[coveralls]

Pull Request Test Coverage Report for Build ce7ef570-7771-4db7-ad07-d78c939e8902

• 1 of 20 (5.0%) changed or added relevant lines in 2 files are covered.
• 56 unchanged lines in 8 files lost coverage.
• Overall coverage increased (+0.0008%) to 56.447%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cmd/server/cadence/server.go	0	19	0.0%

Files with Coverage Reduction	New Missed Lines	%
service/matching/taskListManager.go	2	74.09%
common/cache/lru.go	3	90.73%
service/history/queue/timer_gate.go	3	95.83%
service/history/queue/timer_queue_processor_base.go	4	78.6%
common/task/fifoTaskScheduler.go	5	82.47%
common/persistence/nosql/nosqlExecutionStore.go	9	57.52%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go	14	72.8%
common/persistence/nosql/nosqlTaskStore.go	16	58.37%

Totals
Change from base Build d0fe8b7c-eb9c-4e05-b3aa-a87db96cf4c7:	0.0008%
Covered Lines:	80542
Relevant Lines:	142686

---

💛 - Coveralls