Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for cross cluster implementation #4527

Merged
merged 5 commits into from
Oct 6, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Oct 1, 2021

What changed?

  • Add metrics for cross cluster components
  • Add missing parts in cross-cluster components
  • Handle shard level error when getting cross cluster tasks

Why?

  • Cross-domain operations support

How did you test it?

  • Existing test since it's mostly adding metrics

Potential risks

Release notes

Documentation Changes

@yycptt yycptt requested review from yux0 and demirkayaender October 1, 2021 17:28
@coveralls
Copy link

coveralls commented Oct 1, 2021

Pull Request Test Coverage Report for Build 28f47c14-0562-4119-879f-ed96b5d4f0a9

  • 88 of 155 (56.77%) changed or added relevant lines in 13 files are covered.
  • 161 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.04%) to 56.401%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/task/cross_cluster_target_task_executor.go 0 1 0.0%
service/history/task/task_util.go 20 22 90.91%
common/log/tag/tags.go 0 3 0.0%
service/history/queue/cross_cluster_queue_processor_base.go 0 3 0.0%
service/history/task/cross_cluster_task_processor.go 20 23 86.96%
service/history/task/priority_assigner.go 2 5 40.0%
service/history/task/fetcher.go 24 30 80.0%
service/history/task/cross_cluster_task.go 4 12 33.33%
common/util.go 0 10 0.0%
service/history/shard/context.go 16 29 55.17%
Files with Coverage Reduction New Missed Lines %
service/history/task/fetcher.go 1 86.56%
service/history/task/priority_assigner.go 1 89.74%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 50.23%
common/persistence/statsComputer.go 3 96.07%
common/task/fifoTaskScheduler.go 3 84.54%
common/persistence/serialization/parser.go 4 65.41%
common/persistence/serialization/thrift_decoder.go 4 59.6%
service/history/task/redispatcher.go 4 89.67%
common/persistence/sql/workflowStateMaps.go 17 84.2%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 20 77.03%
Totals Coverage Status
Change from base Build 8115c8a2-5071-44c9-8294-6dfdb02c2349: -0.04%
Covered Lines: 80570
Relevant Lines: 142853

💛 - Coveralls

common/util.go Show resolved Hide resolved
service/history/shard/context.go Outdated Show resolved Hide resolved
@yycptt yycptt merged commit 70cf8be into cadence-workflow:master Oct 6, 2021
@yycptt yycptt deleted the xcluster-metrics branch October 6, 2021 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants