Introduce rpc.Params #4517
Merged
Introduce rpc.Params #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,9 +82,6 @@ func startHandler(c *cli.Context) { | |||
| sigc := make(chan os.Signal, 1) | |||
| signal.Notify(sigc, syscall.SIGTERM) | |||
| for _, svc := range services { | |||
| if _, ok := cfg.Services[svc]; !ok { | |||
There was a problem hiding this comment.
No need to check here. This is checked down the line in server.startService when config is actually needed.
| @@ -70,9 +70,6 @@ func newServer(service string, cfg *config.Config) common.Daemon { | |||
|
|
|||
| // Start starts the server | |||
| func (s *server) Start() { | |||
| if _, ok := s.cfg.Services[s.name]; !ok { | |||
There was a problem hiding this comment.
No need to check here. This is checked down the line in server.startService when config is actually needed.
vytautas-karpavicius
force-pushed
the
rpc-params
branch
3 times, most recently
from
8e5a011 to
dbbe77f
Compare
vytautas-karpavicius
force-pushed
the
rpc-params
branch
from
dbbe77f to
5df06df
Compare
mantas-sidlauskas
approved these changes
Sep 28, 2021
common/rpc/grpc.go
Outdated
Comment on lines
32
to
35
| type ( | ||
| GRPCPortResolver interface { | ||
| GetGRPCAddress(service, hostAddress string) (string, error) | ||
| } |
There was a problem hiding this comment.
Is this interface really needed?
If so, I would make it more general, as it does nothing specific to grpc
There was a problem hiding this comment.
The interface is needed, as integration tests pass different implementation.
But I agree that the name could be more general. Updated it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Introduced
rpc.Paramsstructure that contains required parameters to initializerpc.Factory.This decouples Factory from using config directly. It is beneficial for 2 reasons:
rpc.Factoryin integration tests. Before we had a separate implementation there, with minor differences. Now we can pass those differences via Params.Also refactored service config retrieval into a function. This is now used in couple of places.
Why?
To reduce code duplication and increase test coverage.
How did you test it?
Additional unit tests for refactored code.
Existing tests.
Starting server locally with removed config section.
Potential risks
Release notes
Documentation Changes