Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor service naming constants #4516

Conversation

vytautas-karpavicius
Copy link
Contributor

@vytautas-karpavicius vytautas-karpavicius commented Sep 28, 2021

What changed?
Gathered all service naming related constants, lists and cadence- prefix related functionality in one place under service package.

Why?
To prevent duplication, keep everything in one place.

How did you test it?
Additional unit tests to cover prefix functionlity.
Existing tests.

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build b968a656-6f1d-4fef-bcd8-b4349ab8e400

  • 77 of 108 (71.3%) changed or added relevant lines in 22 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 56.498%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/config/ringpop.go 0 1 0.0%
service/frontend/workflowHandler.go 2 3 66.67%
service/worker/service.go 0 1 0.0%
tools/cli/domainUtils.go 0 1 0.0%
common/domain/handler.go 0 2 0.0%
service/frontend/adminHandler.go 0 2 0.0%
common/resource/resourceTest.go 0 4 0.0%
cmd/server/cadence/server.go 0 8 0.0%
client/clientfactory.go 6 17 35.29%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/execution/mutable_state_builder.go 2 69.77%
service/matching/taskListManager.go 2 74.09%
Totals Coverage Status
Change from base Build 4582c320-9224-4939-8667-b747c0551196: 0.02%
Covered Lines: 80278
Relevant Lines: 142090

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review September 28, 2021 08:40
@vytautas-karpavicius vytautas-karpavicius requested a review from a team September 28, 2021 08:40
Copy link
Contributor

@mantas-sidlauskas mantas-sidlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vytautas-karpavicius vytautas-karpavicius merged commit 5428e35 into cadence-workflow:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants