Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test for internal integration tests #4437

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Refactor test for internal integration tests #4437

merged 3 commits into from
Sep 1, 2021

Conversation

yycptt
Copy link
Contributor

@yycptt yycptt commented Sep 1, 2021

What changed?

  • Export integration test suite definitions
  • Allow specifying schema dir when setting up nosql test cluster

Why?

  • For internal integration tests

How did you test it?

  • Integration tests

Potential risks

Release notes

Documentation Changes

yycptt added 2 commits August 31, 2021 18:39
@yycptt
Refactor test for internal integration tests
abb2cfb 
- Export integration test suite definitions
- Allow specifying schema dir when setting up nosql test cluster
@yycptt
remove unused code
4089ece
@yycptt yycptt requested review from yux0, longquanzheng and a team September 1, 2021 01:50
@coveralls
Copy link

coveralls commented Sep 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build d1dddc46-fecb-499b-a3a1-296a4e9076d9

  • 34 of 37 (91.89%) changed or added relevant lines in 5 files are covered.
  • 39 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.02%) to 56.307%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/persistence-tests/persistenceTestBase.go 0 1 0.0%
common/persistence/nosql/nosqlplugin/cassandra/admin.go 11 13 84.62%
Files with Coverage Reduction New Missed Lines %
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
common/membership/rpServiceResolver.go 2 73.58%
common/persistence/executionManager.go 2 75.5%
common/persistence/statsComputer.go 2 95.71%
common/persistence/nosql/nosqlExecutionStore.go 9 57.52%
service/history/shard/context.go 9 65.23%
service/history/execution/context.go 14 72.11%
Totals Coverage Status
Change from base Build b4be510f-3fff-4fe3-ba33-339c8ab6bf62: -0.02%
Covered Lines: 79131
Relevant Lines: 140534
💛 - Coveralls

longquanzheng
longquanzheng reviewed Sep 1, 2021
View reviewed changes
common/persistence/nosql/nosqlPersistenceTest.go Outdated
func NewTestCluster(
pluginName, keyspace, username, password, host string,
port, protoVersion int,
schemaDir string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about schemaBaseDir? it will sound more "optional" and more accurate based on the actual meaning.

@yycptt yycptt mentioned this pull request Sep 1, 2021
Closed
@yycptt yycptt merged commit 88549dd into cadence-workflow:master Sep 1, 2021
@yycptt yycptt deleted the fix-internal-tests branch September 1, 2021 17:30
yycptt added a commit that referenced this pull request Sep 1, 2021
@yycptt
Refactor test for internal integration tests (#4437)
db77377 
- Export integration test suite definitions
- Allow specifying schema dir when setting up nosql test cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longquanzheng longquanzheng longquanzheng approved these changes

@yux0 yux0 Awaiting requested review from yux0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yycptt @coveralls @longquanzheng