Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context metric tags for admin handler #4404

Conversation

vytautas-karpavicius
Copy link
Contributor

@vytautas-karpavicius vytautas-karpavicius commented Aug 23, 2021

What changed?
Added context metrics tags for admin handler. Context tags currently contain which transport the request is coming from (tchannel or grpc).

Why?
All other handlers have it. It was probably forgotten to add for admin handler as well.

How did you test it?
Verified on staging2

Potential risks

Release notes

Documentation Changes

@vytautas-karpavicius vytautas-karpavicius requested a review from a team August 23, 2021 12:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build b92fbf7b-c4b6-498c-b9d4-0b6f779065c1

  • 7 of 26 (26.92%) changed or added relevant lines in 1 file are covered.
  • 48 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.01%) to 56.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/frontend/adminHandler.go 7 26 26.92%
Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 26.9%
service/history/queue/timer_queue_processor_base.go 1 78.56%
common/membership/rpServiceResolver.go 2 73.58%
service/history/task/transfer_active_task_executor.go 2 71.06%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 49.32%
common/task/fifoTaskScheduler.go 4 85.57%
common/types/mapper/thrift/shared.go 4 65.02%
common/persistence/nosql/nosqlplugin/cassandra/workflowUtils.go 12 75.24%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 19 75.97%
Totals Coverage Status
Change from base Build a9a61159-e980-446b-8089-99d7854a1386: -0.01%
Covered Lines: 78672
Relevant Lines: 139501

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius merged commit 8ad444b into cadence-workflow:master Aug 23, 2021
@vytautas-karpavicius vytautas-karpavicius deleted the admin-handler-ctx-tags branch August 23, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants