gRPC for cross DC traffic #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytautas-karpavicius
force-pushed
the
replication-grpc
branch
from
1a04689 to
89406e7
Compare
vytautas-karpavicius
force-pushed
the
replication-grpc
branch
from
57eab54 to
fb3f0d1
Compare
Shaddoll
reviewed
Aug 24, 2021
client/clientBean.go
Outdated
| @@ -65,9 +66,10 @@ type ( | |||
| SetRemoteFrontendClient(cluster string, client frontend.Client) | |||
| } | |||
|
|
|||
| // DispatcherProvider provides a diapatcher to a given address | |||
| // DispatcherProvider provides a dispatcher to a given address | |||
| DispatcherProvider interface { | |||
| Get(name string, address string) (*yarpc.Dispatcher, error) | |||
There was a problem hiding this comment.
Can you rename it to GetTchannel to make it explicit?
There was a problem hiding this comment.
Yes, updated.
Shaddoll
reviewed
Aug 24, 2021
| @@ -358,3 +374,8 @@ func (cf *rpcClientFactory) newFrontendGRPCClient(hostAddress string) (frontend. | |||
| apiv1.NewVisibilityAPIYARPCClient(config), | |||
| ), nil | |||
| } | |||
|
|
|||
| func isGRPCOutbound(config transport.ClientConfig) bool { | |||
| namer, ok := config.GetUnaryOutbound().(transport.Namer) | |||
There was a problem hiding this comment.
should we panic/log.fatal here if ok==false?
There was a problem hiding this comment.
Unless old version of yarpc is used, this will not happen. But I guess explicit early panic is better. Updated.
Shaddoll
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
DispatcherProviderinterface to support creating dispatchers for gRPC. UpdateddnsDispatcherProviderimplementation to accordingly.ClusterGroupMetadatato allow configuring cross DC transport. If not specified, it defaults totchannel, as currently used.Why?
To support gRPC for cross DC traffic.
How did you test it?
Integration tests for cross DC replication.
Potential risks
TChannel is still used by default, and gRPC is currently opt in to minimize risk.
Release notes
Updated CHANGELOG.md
Documentation Changes