-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added config store functionality (initial implementation) #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic bugs, 90% test coverage
…er unit tests, changes to use configStoreClient, added config to development.yaml
…ed returns all values of specified dc
… config store client values, better adherence to conventions, etc.
This reverts commit ea50165.
yycptt
approved these changes
Aug 13, 2021
Great job! Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adds an alternative dynamic config system other than file-based client. Cadence service takes over responsibility of storing and propagating changes to dynamic configs. Added admin cli commands for operators to manage them. Currently only supports Cassandra as data store.
Why?
Offers a potentially better solution to dynamic config as file-based system can be difficult to use in production environment as all hosts need a local copy. Currently, it is the operator's responsibility to manage syncing this file.
How did you test it?
Tested locally, added unit tests. Made sure it passes canary with both Cassandra and SQL.
Potential risks
Currently, configStore is not enabled by default, so it shouldn't causes any issues that we did not check for already.
Release notes
Updated cassandra schema and cli. Should be backwards compatible with the previous dynamicConfigClient struct in development.yaml if new dynamicconfig struct is not specified.
Documentation Changes