Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Feature Flags for Breaking Changes #4257

Merged

Conversation

demirkayaender
Copy link
Contributor

@demirkayaender demirkayaender commented Jun 7, 2021

What changed?
Note: ignore go.mod changes for now. They will be fixed once the client changes are in

Shipping WorkflowExecutionAlreadyCompletedError broke some customers' workflow logic since it was changing previous contract between their workflow and cadence server. With this change, they can enable the new feature only when they are ready.

Changes need to go in with the following orders

Ignore go.mod/sum changes for now, I will update them once IDL and client changes are in.

Why?
Without this change, shipping new features will break customer workflows.

How did you test it?
go test -run TestIntegrationSuite github.com/uber/cadence/host -testify.m TestSignalWorkflow$ -v

Potential risks

Release notes

Documentation Changes

@demirkayaender demirkayaender force-pushed the feature_flags branch 4 times, most recently from 1c92f5f to a83c213 Compare June 9, 2021 22:56
@demirkayaender demirkayaender force-pushed the feature_flags branch 2 times, most recently from f996369 to 5c66a3c Compare June 10, 2021 02:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4ee32b95-34fc-43c4-aa78-52a472cee6c7

  • 94 of 142 (66.2%) changed or added relevant lines in 14 files are covered.
  • 117 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.03%) to 60.243%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/cli/workflowCommands.go 16 17 94.12%
common/types/mapper/thrift/errors.go 0 4 0.0%
tools/cli/workflowBatchCommands.go 0 4 0.0%
common/types/errors.go 0 5 0.0%
common/types/shared.go 0 5 0.0%
common/client/versionChecker.go 30 37 81.08%
common/types/mapper/proto/errors.go 0 8 0.0%
common/types/mapper/thrift/shared.go 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/executionStore.go 2 75.75%
common/persistence/statsComputer.go 2 96.43%
common/task/weightedRoundRobinTaskScheduler.go 2 89.12%
service/history/execution/mutable_state_builder.go 2 70.02%
service/history/queue/timer_queue_processor.go 2 58.77%
common/cache/lru.go 3 90.73%
common/persistence/cassandra/cassandraPersistence.go 3 54.09%
common/archiver/filestore/historyArchiver.go 4 80.54%
common/types/mapper/thrift/shared.go 4 70.58%
service/history/queue/timer_queue_processor_base.go 4 78.83%
Totals Coverage Status
Change from base Build 4d95b83b-a240-498f-8680-2d4571e321f7: -0.03%
Covered Lines: 88961
Relevant Lines: 147671

💛 - Coveralls

@demirkayaender demirkayaender merged commit 0f93d57 into cadence-workflow:master Jun 10, 2021
@demirkayaender demirkayaender deleted the feature_flags branch June 10, 2021 03:45
@JuanPalacios
Copy link

Is this feature included in the java client?

@demirkayaender
Copy link
Contributor Author

demirkayaender commented Sep 20, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants