-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Feature Flags for Breaking Changes #4257
Merged
demirkayaender
merged 1 commit into
cadence-workflow:master
from
demirkayaender:feature_flags
Jun 10, 2021
Merged
Support Feature Flags for Breaking Changes #4257
demirkayaender
merged 1 commit into
cadence-workflow:master
from
demirkayaender:feature_flags
Jun 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5814c1
to
e834fb3
Compare
This was referenced Jun 7, 2021
yycptt
reviewed
Jun 7, 2021
1c92f5f
to
a83c213
Compare
emrahs
approved these changes
Jun 9, 2021
f996369
to
5c66a3c
Compare
5c66a3c
to
d1fce61
Compare
Is this feature included in the java client? |
Yes, java client supports it. Here's an example usage: https://github.com/uber/cadence-java-samples/blob/e3a0e310435d51c7152b2c904eef960d22fa4f5a/src/main/java/com/uber/cadence/samples/hello/HelloSignal.java#L103 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Note: ignore go.mod changes for now. They will be fixed once the client changes are in
Shipping WorkflowExecutionAlreadyCompletedError broke some customers' workflow logic since it was changing previous contract between their workflow and cadence server. With this change, they can enable the new feature only when they are ready.
Changes need to go in with the following orders
Ignore go.mod/sum changes for now, I will update them once IDL and client changes are in.
Why?
Without this change, shipping new features will break customer workflows.
How did you test it?
go test -run TestIntegrationSuite github.com/uber/cadence/host -testify.m TestSignalWorkflow$ -v
Potential risks
Release notes
Documentation Changes