Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to setup local MySQL and Postgres #3868

Merged
merged 10 commits into from
Jan 7, 2021
Merged

Add instructions to setup local MySQL and Postgres #3868

merged 10 commits into from
Jan 7, 2021

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Dec 28, 2020

What changed?
Add README for local SQL DB setup

Why?
Better contribution support

How did you test it?

Potential risks

@yux0 yux0 requested review from longquanzheng and a team December 28, 2020 21:49
```

Then you will be able to run a basic local Cadence server for development:
```bash
./cadence-server start

# If you use SQL DB, then run:
./cadence-server --zone <mysql/postgres> start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it development_mysql/development_postgres?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the loading logic will automatically append the value for zone to environment when resolving the config file path.

@coveralls
Copy link

coveralls commented Jan 5, 2021

Coverage Status

Coverage increased (+0.002%) to 61.328% when pulling d4853c2 on db_setup into 4f405e9 on master.

@@ -0,0 +1,35 @@
# Setup local MySQL with Docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why readme? this name doesn't give any useful information. Maybe setup?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the dir name

@yux0 yux0 merged commit 218de53 into master Jan 7, 2021
@yux0 yux0 deleted the db_setup branch January 7, 2021 18:19
github-actions bot pushed a commit to vytautas-karpavicius/cadence that referenced this pull request Feb 4, 2021
yux0 added a commit to yux0/cadence that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants