clientVersionCheck: disable by default, enable for localhost devel #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiliang86
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend started enforcing client feature version checks recently. The way this works - it checks if the client SDK version is compatible with the current server version and if not, rejects requests from the client. However, this is broken for the case when cadence-server is rolled back, say, due to a bug. In this case, customers who are using new versions of SDK (which is incompatible with rolled back version of server) will see all requests fail. This isn't ideal since the incompatibility we talk about here is only certain new features which the customer may or may not be using.
This patch disables the client version check by default. The original intention of the version check is to force customers who are testing against localhost to upgrade to latest client sdk version. To meet that goal, this patch enables version check just for the docker container we vend for testing.