Skip to content

Commit

Permalink
handle rpc factory start failure
Browse files Browse the repository at this point in the history
  • Loading branch information
taylanisikdemir committed Nov 4, 2024
1 parent 35cc125 commit 9487ada
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion common/resource/resource_impl.go
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,9 @@ func (h *Impl) Start() {
h.logger.WithTags(tag.Error(err)).Fatal("fail to start PProf")
}

h.rpcFactory.Start(h.membershipResolver)
if err := h.rpcFactory.Start(h.membershipResolver); err != nil {
h.logger.WithTags(tag.Error(err)).Fatal("fail to start RPC factory")
}

Check warning on line 400 in common/resource/resource_impl.go

View check run for this annotation

Codecov / codecov/patch

common/resource/resource_impl.go#L399-L400

Added lines #L399 - L400 were not covered by tests

if err := h.dispatcher.Start(); err != nil {
h.logger.WithTags(tag.Error(err)).Fatal("fail to start dispatcher")
Expand Down

0 comments on commit 9487ada

Please sign in to comment.