Refactor history packages (#5673)

What changed?
Moving structs in the service/history package to their own packages

The handler is moved to it's own package with the interface (like in frontend)
The handler wrappers (grpc, and thrift) are moved to their own packages under wrapped (like in frontend)

The engine implementation is moved to it's own package as there was a circular dependency
history (service) -> handler -> history (engine)
and the engine implementation cannot be in the same package as the engine interface, as there is a dependency
engineimpl -> shard -> engine (Interface)

Moved all the error values in handler to a constants package as at least one of them (ErrRunIDNotValid) is referenced from two different packages (handler and engineimpl tests)

Why?
We should not have this much in the same package

Also when service and handler are in the same package we cannot introduce wrappers around handler in any other package than history as that will create a circular dependency:
history (service) -> wrapper -> history (handler)

How did you test it?
Ran unit tests

Potential risks
It just moves things around, so no real code changes

Release notes

Documentation Changes

host/integration_test.go

@@ -40,7 +40,7 @@ import (
 	"github.com/uber/cadence/common"
 	"github.com/uber/cadence/common/log/tag"
 	"github.com/uber/cadence/common/types"
-	cadencehistory "github.com/uber/cadence/service/history"
+	"github.com/uber/cadence/service/history/engine/engineimpl"
 	"github.com/uber/cadence/service/history/execution"
 	"github.com/uber/cadence/service/matching"
 )
@@ -309,8 +309,8 @@ GetHistoryLoop:
 		}
 
 		terminateEventAttributes := lastEvent.WorkflowExecutionTerminatedEventAttributes
-		s.Equal(cadencehistory.TerminateIfRunningReason, terminateEventAttributes.GetReason())
-		s.Equal(fmt.Sprintf(cadencehistory.TerminateIfRunningDetailsTemplate, we1.GetRunID()), string(terminateEventAttributes.Details))
+		s.Equal(engineimpl.TerminateIfRunningReason, terminateEventAttributes.GetReason())
+		s.Equal(fmt.Sprintf(engineimpl.TerminateIfRunningDetailsTemplate, we1.GetRunID()), string(terminateEventAttributes.Details))
 		s.Equal(execution.IdentityHistoryService, terminateEventAttributes.GetIdentity())
 		executionTerminated = true
 		break GetHistoryLoop

host/signal_workflow_test.go

@@ -37,7 +37,7 @@ import (
 	"github.com/uber/cadence/common/client"
 	"github.com/uber/cadence/common/log/tag"
 	"github.com/uber/cadence/common/types"
-	cadencehistory "github.com/uber/cadence/service/history"
+	"github.com/uber/cadence/service/history/engine/engineimpl"
 	"github.com/uber/cadence/service/history/execution"
 )
 
@@ -1655,8 +1655,8 @@ GetHistoryLoop:
 		}
 
 		terminateEventAttributes := lastEvent.WorkflowExecutionTerminatedEventAttributes
-		s.Equal(cadencehistory.TerminateIfRunningReason, terminateEventAttributes.GetReason())
-		s.Equal(fmt.Sprintf(cadencehistory.TerminateIfRunningDetailsTemplate, resp1.GetRunID()), string(terminateEventAttributes.Details))
+		s.Equal(engineimpl.TerminateIfRunningReason, terminateEventAttributes.GetReason())
+		s.Equal(fmt.Sprintf(engineimpl.TerminateIfRunningDetailsTemplate, resp1.GetRunID()), string(terminateEventAttributes.Details))
 		s.Equal(execution.IdentityHistoryService, terminateEventAttributes.GetIdentity())
 		executionTerminated = true
 		break GetHistoryLoop

service/history/constants/constants.go

@@ -0,0 +1,38 @@
+// The MIT License (MIT)
+
+// Copyright (c) 2017-2020 Uber Technologies Inc.
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in all
+// copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+// SOFTWARE.
+
+package constants
+
+import "github.com/uber/cadence/common/types"
+
+var (
+	ErrDomainNotSet            = &types.BadRequestError{Message: "Domain not set on request."}
+	ErrWorkflowExecutionNotSet = &types.BadRequestError{Message: "WorkflowExecution not set on request."}
+	ErrTaskListNotSet          = &types.BadRequestError{Message: "Tasklist not set."}
+	ErrRunIDNotValid           = &types.BadRequestError{Message: "RunID is not valid UUID."}
+	ErrWorkflowIDNotSet        = &types.BadRequestError{Message: "WorkflowId is not set on request."}
+	ErrSourceClusterNotSet     = &types.BadRequestError{Message: "Source Cluster not set on request."}
+	ErrTimestampNotSet         = &types.BadRequestError{Message: "Timestamp not set on request."}
+	ErrInvalidTaskType         = &types.BadRequestError{Message: "Invalid task type"}
+	ErrHistoryHostThrottle     = &types.ServiceBusyError{Message: "History host rps exceeded"}
+	ErrShuttingDown            = &types.InternalServiceError{Message: "Shutting down"}
+)

service/history/historyEngine.go → service/history/engine/engineimpl/historyEngine.go

@@ -19,7 +19,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
-package history
+package engineimpl
 
 import (
 	"bytes"

service/history/historyEngine2_test.go → service/history/engine/engineimpl/historyEngine2_test.go

@@ -18,7 +18,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
-package history
+package engineimpl
 
 import (
 	"context"

service/history/historyEngine3_eventsv2_test.go → service/history/engine/engineimpl/historyEngine3_eventsv2_test.go

@@ -18,7 +18,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
-package history
+package engineimpl
 
 import (
 	"context"

service/history/historyEngine_test.go → service/history/engine/engineimpl/historyEngine_test.go

@@ -19,7 +19,7 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
 
-package history
+package engineimpl
 
 import (
 	"context"
@@ -228,7 +228,7 @@ func (s *engineSuite) TestGetMutableState_IntestRunID() {
 		DomainUUID: constants.TestDomainID,
 		Execution:  &execution,
 	})
-	s.Equal(errRunIDNotValid, err)
+	s.Equal(constants.ErrRunIDNotValid, err)
 }
 
 func (s *engineSuite) TestGetMutableState_EmptyRunID() {