Fix domain updating via grpc (#4418)

cadence-workflow · Aug 25, 2021 · 76573a2 · 76573a2
1 parent 6dec5aa
commit 76573a2
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/common/types/mapper/proto/api.go b/common/types/mapper/proto/api.go
@@ -4025,7 +4025,6 @@ func ToUpdateDomainRequest(t *apiv1.UpdateDomainRequest) *types.UpdateDomainRequ
 	request := types.UpdateDomainRequest{
 		Name:          t.Name,
 		SecurityToken: t.SecurityToken,
-		EmitMetric:    common.BoolPtr(true), // DEPRECATED - defaults to true
 	}
 	fs := newFieldSet(t.UpdateMask)
 

diff --git a/common/types/mapper/proto/api_test.go b/common/types/mapper/proto/api_test.go
@@ -686,7 +686,7 @@ func TestTimerStartedEventAttributes(t *testing.T) {
 	}
 }
 func TestUpdateDomainRequest(t *testing.T) {
-	for _, item := range []*types.UpdateDomainRequest{nil, {EmitMetric: common.BoolPtr(true)}, &testdata.UpdateDomainRequest} {
+	for _, item := range []*types.UpdateDomainRequest{nil, {}, &testdata.UpdateDomainRequest} {
 		assert.Equal(t, item, ToUpdateDomainRequest(FromUpdateDomainRequest(item)))
 	}
 }

diff --git a/common/types/testdata/service_frontend.go b/common/types/testdata/service_frontend.go
@@ -69,7 +69,6 @@ var (
 		OwnerEmail:                             common.StringPtr(DomainOwnerEmail),
 		Data:                                   DomainData,
 		WorkflowExecutionRetentionPeriodInDays: common.Int32Ptr(DomainRetention),
-		EmitMetric:                             common.BoolPtr(DomainEmitMetric),
 		BadBinaries:                            &BadBinaries,
 		HistoryArchivalStatus:                  &ArchivalStatus,
 		HistoryArchivalURI:                     common.StringPtr(HistoryArchivalURI),