Skip to content

Commit

Permalink
comment
Browse files Browse the repository at this point in the history
  • Loading branch information
longquanzheng authored Sep 10, 2021
1 parent ff3759c commit 6efb5c6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions canary/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ For local development, you can also start the cron canary workflows along with t
./cadence-canary start -m all
```

The Cron Schedule is from the Configuration.
However, changing the schedule requires you manually terminate the existing cron workflow to take into effect.
It can be [improved](https://github.com/uber/cadence/issues/4469) in the future.

#### Test case starter & Sanity suite
The sanity workflow is test suite workflow. It will kick off a bunch of childWorkflows for all the test to verify that Cadence server is operating correctly.

Expand Down
1 change: 1 addition & 0 deletions canary/canary.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ func (c *canaryImpl) startCronWorkflow() {
_, err := c.canaryClient.StartWorkflow(ctx, opts, cronWorkflow, wfTypeSanity)
if err != nil {
// TODO: improvement: compare the cron schedule to decide whether or not terminating the current one
// https://github.com/uber/cadence/issues/4469
if _, ok := err.(*shared.WorkflowExecutionAlreadyStartedError); !ok {
c.runtime.logger.Error("error starting cron workflow", zap.Error(err))
} else {
Expand Down

0 comments on commit 6efb5c6

Please sign in to comment.