Skip to content

Conversation

adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Aug 26, 2025

Summary

Show active cluster(s) based on activeClustersByRegion for an active-active domain, in Domain Metadata

Test plan

Updated unit tests + ran locally.

Screenshot 2025-08-25 at 1 37 11 PM

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Implements correct active/passive status determination for active-active domains in the Domain Metadata section by introducing a new helper function that checks activeClustersByRegion instead of relying solely on activeClusterName.

  • Created isActiveCluster helper to handle both active-active and active-passive domain logic
  • Updated cluster metadata component to use the new helper for accurate status labeling
  • Added comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/views/domain-page/helpers/is-active-cluster.ts New helper function to determine if a cluster is active based on domain type
src/views/domain-page/helpers/__tests__/is-active-cluster.test.ts Unit tests for the new helper function covering both domain types
src/views/domain-page/domain-page-metadata-clusters/domain-page-metadata-clusters.tsx Updated to use new helper instead of direct activeClusterName comparison
src/views/domain-page/domain-page-metadata-clusters/__tests__/domain-page-metadata-clusters.test.tsx Added mocking for the new helper function in existing tests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@adhityamamallan adhityamamallan merged commit bab4502 into cadence-workflow:master Aug 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants