Show message for missing archival result #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...summary-tab/workflow-summary-tab-json-view/__tests__/workflow-summary-tab-json-view.test.tsx
Outdated
Show resolved
Hide resolved
| ) : ( | ||
| <PrettyJson json={jsonMap[activeTab]} /> | ||
| {activeTab === 'input' && <PrettyJson json={jsonMap[activeTab]} />} | ||
| {activeTab === 'result' && isArchived && ( |
There was a problem hiding this comment.
I think the if-else logic for the result rendering could be simplified a bit, but I'm not sure if there's a better way to do that besides moving it to a different component.
There was a problem hiding this comment.
Moving it to a separate component was one of the things that i considered, while i didn't go for an extra separation since the logic is still manageable (75 lines).
...views/workflow-summary-tab/workflow-summary-tab-json-view/workflow-summary-tab-json-view.tsx
Outdated
Show resolved
Hide resolved
...views/workflow-summary-tab/workflow-summary-tab-json-view/workflow-summary-tab-json-view.tsx
Outdated
Show resolved
Hide resolved
.../workflow-summary-tab/workflow-summary-tab-json-view/workflow-summary-tab-json-view.types.ts
Outdated
Show resolved
Hide resolved
…__tests__/workflow-summary-tab-json-view.test.tsx Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com>
…workflow-summary-tab-json-view.tsx Co-authored-by: Adhitya Mamallan <adi1998is@gmail.com>
adhityamamallan
approved these changes
Aug 13, 2025
| )} | ||
| {activeTab === 'result' && !isArchived && ( | ||
| <> | ||
| {isWorkflowRunning && <PrettyJsonSkeleton width="200px" />} |
There was a problem hiding this comment.
Maybe for later, but we can replace this placeholder with a more useful "workflow is still running" message
Assem-Uber
deleted the
feature/show-message-for-archival-result-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close event is not available in the response of
describeWorkflowfor archival events. This makes result tab keeps showing loading. Instead we need to show users a message indicating that result won't be available in summary page for archival workflowsScreenshots
Note:
throughwas replaced byin, screenshot is not up to date.