Add feature flag for archival default search #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhityamamallan
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add flag to enable/disable showing the default search input for archival workflows page. This won't affect the query input, so users can still write queries to filter archival workflows. This change is needed since default search supported by other pages (basic workflows list, advanced workflow list) uses querying features that is not supported by S3 (The default archival storage).
The search input can be shown by setting environment variable
CADENCE_ARCHIVAL_DEFAULT_SEARCH_ENABLED=true. This can be useful in cases were archival storage implementation supports advanced querying tokens such as<><=>=.