Load and display Workflow Diagnostics in a placeholder component #948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhityamamallan
changed the title
Assem-Uber
reviewed
Jul 17, 2025
| overrides={overrides.viewToggleSegment} | ||
| /> | ||
| </SegmentedControl> | ||
| {/* Add a button here to expand all diagnostics issues, hide in JSON mode ofc */} |
There was a problem hiding this comment.
nit: Better add a TODO prefix for the comment to easily spot that it is not a description comment
There was a problem hiding this comment.
I'll be addressing it this sprint anyway, so it's very unlikely I'll miss it 😅
Assem-Uber
approved these changes
Jul 17, 2025
adhityamamallan
force-pushed
the
diagnostics-content
branch
from
8775906 to
1998a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Unit tests + ran locally.