Add JSON viewer/downloader for DescribeDomain API response #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/config/dynamic/resolvers/extended-domain-info-enabled.ts:5
- Changing the default value of 'metadata' from false to true is a significant behavioral update; please verify that downstream consumers are adjusted accordingly.
metadata: true,
adhityamamallan
force-pushed
the
describe-domain-json
branch
from
25baca4 to
76342dc
Compare
adhityamamallan
force-pushed
the
describe-domain-json
branch
from
76342dc to
45d625a
Compare
Assem-Uber
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Added & updated unit tests + ran locally.
Also sanity-checked that Workflow History downloading works as expected.
On narrow screens:
