Make time select in date filter editable #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datepicker used allows users to select time range. We populate the time select with time interval of 15 minutes. Adding more granular time options hampers the performance of the component. However, the users often need to specify time intervals that does not align with the options present. This change adds the `creatable` flag to the time select to enable this. Please note that the `creatable` flag in the underlying BaseWeb component is not quite intuitive.
adhityamamallan
approved these changes
Feb 25, 2025
Assem-Uber
pushed a commit
to Assem-Uber/cadence-web
that referenced
this pull request
Mar 3, 2025
The datepicker used allows users to select time range. We populate the time select with time interval of 15 minutes. Adding more granular time options hampers the performance of the component. However, the users often need to specify time intervals that does not align with the options present. This change adds the `creatable` flag to the time select to enable this. Please note that the `creatable` flag in the underlying BaseWeb component is not quite intuitive.
Assem-Uber
added a commit
that referenced
this pull request
Mar 3, 2025
* change calculations for hasMissingEvents * lint fix * Make time select in date filter editable (#838) The datepicker used allows users to select time range. We populate the time select with time interval of 15 minutes. Adding more granular time options hampers the performance of the component. However, the users often need to specify time intervals that does not align with the options present. This change adds the `creatable` flag to the time select to enable this. Please note that the `creatable` flag in the underlying BaseWeb component is not quite intuitive. * fix hasMissingEvents for timeouts * Create useThrottledState * use defaultThrottleSettings * fix failing test * Show loading indicator and load missing events * fix lint * fix types * fix lint * revert status changes * rename helper * rename method * remove statusReady from WorkflowHistoryTimelineGroup --------- Co-authored-by: Pandey Anshuman Kishore <pandeyanshuman@users.noreply.github.com> Co-authored-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datepicker used allows users to select time range. We populate the time select with time interval of 15 minutes. Adding more granular time options hampers the performance of the component. However, the users often need to specify time intervals that does not align with the options present. This change adds the
creatableflag to the time select to enable this.Please note that the
creatableflag in the underlying BaseWeb component is not quite intuitive.