Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/workflows refactoring #112

Merged
merged 6 commits into from
Mar 27, 2020
Merged

Feature/workflows refactoring #112

merged 6 commits into from
Mar 27, 2020

Conversation

just-at-uber
Copy link
Contributor

Changes:

  • Adding Workflows & Settings tabs at domain level route
  • moving domain/config to domain/settings route with redirect
  • Removing config cog in main navigation (can now be accessed by Settings tab)
  • Removing workflows breadcrumb (this is clear by Workflows tab)
  • Fixing spinner to now be in a fixed position instead of by height of current viewport
  • Refactoring workflows screen to be more deterministic (rather than having to recalculate query strings). This can be seen in integration test fixes.

I think there is more to do here but don't want to spend too much time in this area for now.

Screenshots

Screen Shot 2020-03-25 at 1 38 11 PM

Screen Shot 2020-03-25 at 1 39 03 PM

@just-at-uber just-at-uber merged commit bfccddd into master Mar 27, 2020
@just-at-uber just-at-uber deleted the feature/workflows-refactoring branch March 27, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajbogh ajbogh ajbogh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@just-at-uber @ajbogh