Fix/open date range #102
Merged
Fix/open date range #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tching from open to close will limit to max retention if range is greater
ajbogh
reviewed
Mar 13, 2020
|
|
||
| if (minStartDate && date.isBefore(minStartDate)) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
These if statements can be merged together.
return date.isValid &&
!date.isAfter(maxEndDate) &&
!(minStartDate && date.isBefore(minStartDate));
There was a problem hiding this comment.
yea good point. I will make the change. Thanks!
ajbogh
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for an Open workflow, there should not be any minimum start date disabled as retention period does not apply to open workflows (only closed workflows).
Screenshots