Fixed some test issues

cadence-workflow · Jun 13, 2019 · 374b304 · 374b304
1 parent 76564f7
commit 374b304
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 8 deletions.
diff --git a/client/test/execution.test.js b/client/test/execution.test.js
@@ -20,8 +20,8 @@ describe('Execution', function() {
 
     scenario.withFullHistory(opts.events)
 
-    var summaryEl = await scenario.render(opts.attach).waitUntilExists('section.execution section.execution-summary')
-    return [summaryEl, scenario]
+    var summaryEl = await scenario.render(opts.attach).waitUntilExists('section.execution section.execution-summary dl')
+    return [summaryEl.parentElement, scenario]
   }
 
   const closedWorkflowExecution = {
@@ -59,8 +59,8 @@ describe('Execution', function() {
       '/domain/ci-test/workflows/email-daily-summaries/emailRun1/stack-trace',
       '/domain/ci-test/workflows/email-daily-summaries/emailRun1/queries'
     ])
-    scenario.vm.$el.querySelector('section.execution > nav a.stack-trace').should.be.displayed
-    scenario.vm.$el.querySelector('section.execution > nav a.queries').should.be.displayed
+    scenario.vm.$el.querySelector('section.execution > nav a.stack-trace').should.not.have.property("display", "none")
+    scenario.vm.$el.querySelector('section.execution > nav a.queries').should.not.have.property("display", "none")
   })
 
   describe('Summary', function() {
@@ -79,7 +79,7 @@ describe('Execution', function() {
       summaryEl.should.not.have.descendant('.pending-activities')
       summaryEl.should.not.have.descendant('.parent-workflow')
       summaryEl.querySelector('.workflow-status dd').should.contain.text('running')
-      summaryEl.querySelector('.workflow-status loader.bar').should.be.displayed
+      summaryEl.querySelector('.workflow-status loader.bar').should.not.have.property("display", "none")
     })
 
     it('should show the input of the workflow, and any pending events', async function () {

diff --git a/server/test/domain.test.js b/server/test/domain.test.js
@@ -6,11 +6,17 @@ describe('Describe Domain', function() {
         status: 'REGISTERED',
         description: 'domain for running CI tests',
         ownerEmail: 'cadence-dev@uber.com',
-        data: null
+        data: null,
+        uuid: null
       },
       isGlobalDomain: false,
       failoverVersion: 0,
       configuration: {
+        archivalBucketName: null,
+        archivalBucketOwner: null,
+        archivalRetentionPeriodInDays: null,
+        archivalStatus: null,
+        badBinaries: null,
         emitMetric: false,
         workflowExecutionRetentionPeriodInDays: 14
       },
@@ -39,11 +45,17 @@ describe('Describe Domain', function() {
         status: 'REGISTERED',
         description: 'ci test domain',
         ownerEmail: null,
-        data: {}
+        data: {},
+        uuid: null
       },
       failoverVersion: 0,
       isGlobalDomain: true,
       configuration: {
+        archivalBucketName: null,
+        archivalBucketOwner: null,
+        archivalRetentionPeriodInDays: null,
+        archivalStatus: null,
+        badBinaries: null,
         workflowExecutionRetentionPeriodInDays: 14,
         emitMetric: true
       },

diff --git a/server/test/history.test.js b/server/test/history.test.js
@@ -21,10 +21,22 @@ wfHistoryThrift = [{
     childPolicy: 'TERMINATE',
     expirationTimestamp: null,
     continuedExecutionRunId: null,
+    continuedFailureDetails: null,
+    continuedFailureReason: null,
+    cronSchedule: null,
+    firstDecisionTaskBackoffSeconds: null,
+    firstExecutionRunId: null,
+    header: null,
+    initiator: null,
+    lastCompletionResult: null,
+    memo: null,
+    originalExecutionRunId: null,
     parentInitiatedEventId: null,
     parentWorkflowDomain: null,
     parentWorkflowExecution: null,
+    prevAutoResetPoints: null,
     retryPolicy: null,
+    searchAttributes: null,
     taskStartToCloseTimeoutSeconds: 30,
     executionStartToCloseTimeoutSeconds: 1080
   }
@@ -119,6 +131,7 @@ describe('Workflow History', function() {
       .expect(200)
       .expect('Content-Type', /json/)
       .expect({
+        archived: null,
         history: { events: [] },
         nextPageToken: 'cGFnZTM='
       })
@@ -150,6 +163,7 @@ describe('Workflow History', function() {
       .get('/api/domain/canary/workflows/ci%2Fdemo/run1/history')
       .expect(200)
       .expect({
+        archived: null,
         history: { events: wfHistoryJson },
         nextPageToken: 'cGFnZTI='
       })

diff --git a/server/test/workflows.test.js b/server/test/workflows.test.js
@@ -10,7 +10,13 @@ describe('Listing Workflows', function() {
     startTime: dateToLong('2017-11-10T21:30:00.000Z'),
     closeTime: null,
     closeStatus: null,
-    historyLength: null
+    historyLength: null,
+    autoResetPoints: null,
+    executionTime: null,
+    memo: null,
+    parentDomainId: null,
+    parentExecution: null,
+    searchAttributes: null
   },
   demoExecJson = Object.assign({}, demoExecThrift, {
     startTime: '2017-11-10T21:30:00.000Z',