Fix/workflow id with hash (#234)

* escaping hash and forward slash for resolving workflow id * fix lint * adding unit tests * fix lint * 3.20.1-beta.0 * adding esm for news package. removing package-lock * 3.20.1-beta.1 * reverting version * switching to use encodeURIComponent * 3.20.1-beta.2 * fix lint * removing escaped string helpers * reverting package version
cadence-workflow · Jan 6, 2021 · 19d0d42 · 19d0d42
1 parent 2f216d9
commit 19d0d42
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 10,705 deletions.
diff --git a/client/helpers/get-escaped-forward-slash.js b/client/helpers/get-escaped-forward-slash.js
diff --git a/client/helpers/get-escaped-forward-slash.spec.js b/client/helpers/get-escaped-forward-slash.spec.js
diff --git a/client/helpers/index.js b/client/helpers/index.js
@@ -25,7 +25,6 @@ export { default as getEnvironment } from './get-environment';
 export { default as getEnvironmentList } from './get-environment-list';
 export { default as getEnvironmentLocation } from './get-environment-location';
 export { default as getErrorMessage } from './get-error-message';
-export { default as getEscapedForwardSlash } from './get-escaped-forward-slash';
 export { default as getJsonStringObject } from './get-json-string-object';
 export { default as getKeyValuePairs } from './get-key-value-pairs';
 export { default as getLatestNewsItems } from './get-latest-news-items';

diff --git a/client/main.js b/client/main.js
@@ -55,12 +55,7 @@ import WorkflowList from './routes/domain/workflow-list';
 import WorkflowSummary from './routes/workflow/summary';
 import WorkflowTabs from './routes/workflow';
 
-import {
-  getEscapedForwardSlash,
-  http,
-  injectMomentDurationFormat,
-  jsonTryParse,
-} from '~helpers';
+import { http, injectMomentDurationFormat, jsonTryParse } from '~helpers';
 
 const routeOpts = {
   mode: 'history',
@@ -164,7 +159,7 @@ const routeOpts = {
       props: ({ params }) => ({
         domain: params.domain,
         runId: params.runId,
-        workflowId: getEscapedForwardSlash(params.workflowId),
+        workflowId: encodeURIComponent(params.workflowId),
       }),
       children: [
         {
@@ -176,7 +171,7 @@ const routeOpts = {
           props: {
             summary: ({ params }) => ({
               runId: params.runId,
-              workflowId: getEscapedForwardSlash(params.workflowId),
+              workflowId: encodeURIComponent(params.workflowId),
             }),
           },
         },
@@ -193,7 +188,7 @@ const routeOpts = {
               format: query.format || 'grid',
               runId: params.runId,
               showGraph: Boolean(query.showGraph) === true,
-              workflowId: getEscapedForwardSlash(params.workflowId),
+              workflowId: encodeURIComponent(params.workflowId),
             }),
           },
         },