add serviceclient exceptions #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
requested review from
Groxx,
abhishekj720,
natemort,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
natemort
approved these changes
Apr 8, 2025
| @@ -0,0 +1,4 @@ | |||
| package com.uber.cadence.serviceclient.exceptions; | |||
|
|
|||
| public class QueryFailedException extends ServiceClientException { | |||
| @@ -0,0 +1,4 @@ | |||
| package com.uber.cadence.serviceclient.exceptions; | |||
|
|
|||
| public class StickyWorkerUnavailableException extends ServiceClientException { | |||
There was a problem hiding this comment.
This is unused and I don't think can actually propagate to the client
|
|
||
| Status status = StatusProto.fromThrowable(e); | ||
| if (status == null || status.getDetailsCount() == 0) { | ||
| return new ServiceClientException("empty status or status with empty details", e); |
There was a problem hiding this comment.
Nit: When can this happen? What kind of exception does GRPC throw if we have a connection issue rather than an error returned by the server?
There was a problem hiding this comment.
Server controls whether to pass details. https://github.com/uber/cadence/blob/f4e219ae4248552e53a8ba57036b9af62485221b/common/types/mapper/proto/errors.go#L274
I've simplified the logic to handle such cases.
shijiesheng
merged commit adcc039
into
cadence-workflow:feature/issue-985/thrift-deprecation
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
thrift exceptions are used across Java SDK. It's easier to abstract the protocol level error handling by introducing internal exception layer
How did you test it?
Potential risks
Release notes
Documentation Changes