Skip to content

Conversation

c-warren
Copy link
Contributor

@c-warren c-warren commented Oct 6, 2025

What changed?

Allow gpg signed commits to pass DCO checks

Why?

DCO has been introduced to verify that each commit in the repository has been signed-off by the developer who is committing it. There are two ways to do this:

  • `git commit -s -m "my message"
  • sign each commit with a gpg key

This PR allows both of these methods to pass the check, rather than just the first.

How did you test it?

In the cadence repo.

Potential risks

N/A

@c-warren c-warren changed the title <!-- Describe what has changed in this PR --> **What changed?** Allow gpg signed commits to pass DCO checks <!-- Tell your future self why have you made these changes --> **Why?** DCO has been introduced to verify that each commit in the repository has been signed-off by the developer who is committing it. There are two ways to do this: - `git commit -s -m "my message" - sign each commit with a gpg key This PR allows both of these methods to pass the check, rather than just the first. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** [In the cadence repo. ](https://github.com/cadence-workflow/cadence) <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** N/A ci: Support gpg key signed commits Oct 6, 2025
Signed-off-by: Chris Warren <16132615+c-warren@users.noreply.github.com>
@c-warren c-warren merged commit 1771f9b into cadence-workflow:master Oct 6, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants