remove unnecessary TaskListKind internal entity#1023
Merged
shijiesheng merged 1 commit intocadence-workflow:masterfrom Sep 15, 2025
Merged
remove unnecessary TaskListKind internal entity#1023shijiesheng merged 1 commit intocadence-workflow:masterfrom
shijiesheng merged 1 commit intocadence-workflow:masterfrom
Conversation
shijiesheng
requested review from
Groxx,
abhishekj720,
demirkayaender,
dkrotx,
natemort and
taylanisikdemir
as code owners
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
shijiesheng
force-pushed
the
remove-task-list-kind
branch
from
7a3373c to
00585b0
Compare
natemort
approved these changes
Sep 15, 2025
Member
natemort
left a comment
natemort
left a comment
There was a problem hiding this comment.
Makes sense, thanks.
Since it's internal only this should be safe to remove.
pandeyanshuman
pushed a commit
to pandeyanshuman/cadence-java-client
that referenced
this pull request
Oct 13, 2025
What changed? Remove internal TaskListKind entity use thrift entity directly (like everywhere else in the repo) Why? This complicates things and particularly for thrift deprecation How did you test it? Unit Test Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
This complicates things and particularly for thrift deprecation
How did you test it?
Unit Test
Potential risks
Release notes
Documentation Changes