Thrift Deprecation Part 1: replace thrift entities with internal ones #1022
+10,262
−14,744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
requested review from
Groxx,
abhishekj720,
natemort,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
What changed? added client entities that maps 1:1 with thrift (generated from a generator) added BaseError, which is a catchall similar to TException. added mappers to transform Proto to client entities. (mostly copied from thrift mappers) added IWorkflowServiceV4 which is exactly same as IWorkflowService except for it's using the client entities. added WorkflowServiceGrpc that implements the V4 interface Plan new V4 interface with new entities < This PR replace all pointers to V4 in one go (Should be import change only) Why? Thrift deprecation work How did you test it? Unit Test on mappers from ClientObjects to ProtoObjects
* move com.uber.cadence.entities to com.uber.cadence * remove thrift entities * change all imports * replace IWorkflowService with IWorkflowServiceV4 * fix unit test except for replayer test * fix replayer test
This reverts commit c639a34.
This reverts commit 18aa88e.
Signed-off-by: Shijie Sheng <liouvetren@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Release notes
Documentation Changes