Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forward_auth.md example #428

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix forward_auth.md example #428

merged 1 commit into from
Oct 28, 2024

Conversation

teodorescuserban
Copy link
Contributor

@teodorescuserban teodorescuserban commented Oct 28, 2024 •
edited
Loading

request_header doesn't seem to accept multiple headers at a time.

@teodorescuserban
Update forward_auth.md example
26fcc10 
request_header doesn't seem to accept multiple headers at a time.
mholt
mholt approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, this is true; though probably an improvement that could be made for the syntax as well, to work like header (where you can specify a block).

@mholt mholt merged commit e9db589 into caddyserver:master Oct 28, 2024
@teodorescuserban
Copy link
Contributor Author

Indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teodorescuserban @mholt