Repository navigation
Conversation
steadytao
added
bug 🐞
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8222 - Supersedes #8223
Docs caddyserver/website#585
Summary
Follow active health-check redirects only while the destination remains within the original origin. Reject changes to the scheme, host or effective port before issuing another request because the configured health-check transport may contain credentials which cannot be safely removed from arbitrary transport modules.
This prevents both previous failure modes of redirected requests are no longer sent back to the original backend, and custom health headers or transport credentials are not forwarded to a cross-origin target. Relative and absolute same-origin redirects remain supported. Origin comparison handles case-insensitive hostnames, IPv6 addresses and explicit default HTTP and HTTPS ports.
Assistance Disclosure
Used Claude to review all commits since 2.11.4 for issues as there has been a couple regression-like things recently that I and others have let through. Found this. Code authored by me.