headers: Make ApplyTo nil-safe #7426
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When JSON config contains "response": {} in reverse_proxy or headers
middleware, the RespHeaderOps struct is created but the embedded
*HeaderOps pointer is nil. Calling ApplyTo on this nil pointer causes
a panic.
This is a follow-up to af2d33a which made Provision nil-safe for the
same reason. This change applies the same pattern to ApplyTo.
Related to caddyserver#6893
Signed-off-by: Tom Paulus <tpaulus@cloudflare.com>
|
|
francislavoie
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When JSON config contains "response": {} in reverse_proxy or headers middleware, the RespHeaderOps struct is created but the embedded *HeaderOps pointer is nil. Calling ApplyTo on this nil pointer causes a panic.
This is a follow-up to af2d33a which made Provision nil-safe for the same reason. This change applies the same pattern to ApplyTo.
Related to #6893
Assistance Disclosure
Claude Code was consulted for this code, but I authored/coded it myself.