Skip to content

devenv: fix race conditions setting up the shell during tests #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 25, 2025

Conversation

sandydoo
Copy link
Member

Evaluates the dev env once and applies it to both the spawned processes and the tests. This reduces the number of shell evaluations we need to do and prevents task conflicts.

Copy link

cloudflare-workers-and-pages bot commented Apr 22, 2025

Deploying devenv with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1ebd469
Status: ✅  Deploy successful!
Preview URL: https://7c4d246e.devenv.pages.dev
Branch Preview URL: https://fix-test-race.devenv.pages.dev

View logs

@sandydoo sandydoo force-pushed the fix-test-race branch 2 times, most recently from b852e70 to 96c272a Compare April 23, 2025 16:01
@sandydoo sandydoo marked this pull request as ready for review April 25, 2025 09:49
@domenkozar domenkozar merged commit 4a0c25d into main Apr 25, 2025
200 of 277 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants