Clean up naming in image builder workflow #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
How should I test it? I have no permission to start this workflow manually. |
tillkruss
requested changes
Aug 1, 2023
tillkruss
approved these changes
Aug 1, 2023
Contributor
Author
|
I think the naming is esoteric again. |
Contributor
Author
|
The output looks like this project is not open-souce (not welcoming) but for internal use only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First I've started up with adding checks for Dockerfiles using Hadolint.
Then I've read the current
docker.ymlfile and got mental dizziness 😵This PR cleans up naming and a few problems in the workflow file.
Replaces ❌esoteric names with publicly understandable ones.
One of my sources: https://docs.docker.com/engine/reference/commandline/build/